Fix call to logger #11603
Merged
Fix call to logger #11603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
MorrisJobke
requested changes
Oct 3, 2018
apps/theming/lib/ImageManager.php
Outdated
| @@ -117,7 +117,7 @@ public function getImage(string $key, bool $useSvg = true): ISimpleFile { | |||
| $pngFile = $folder->newFile($key . '.png'); | |||
| $pngFile->putContent($finalIconFile->getImageBlob()); | |||
| } catch (\ImagickException $e) { | |||
| $this->logger->info('The image was requested to be no SVG file, but converting it to PNG failed.', $e->getMessage()); | |||
| $this->logger->info('The image was requested to be no SVG file, but converting it to PNG failed.', [$e->getMessage()]); | |||
There was a problem hiding this comment.
I guess we should add it to the message otherwise it's just lost. Could you add it to the message itself by string concatenation?
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
MorrisJobke
approved these changes
Oct 3, 2018
ChristophWurst
approved these changes
Oct 3, 2018
ChristophWurst
added
4. to release
|
@danielkesselberg Mind to do a backport to the stable branches 13 and 14? |
|
Backport for stable14 in #11610. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument 2 passed to OC\\Log::info() must be of the type array, string given, called in \/var\/www\/html\/nextcloud\/apps\/theming\/lib\/ImageManager.php on line 120server/lib/public/ILogger.php
Line 129 in 38a9013